build: increase macOS minimum supported version #21883
Conversation
Starting with V8 6.8, it will not be possible to build with macOS 10.10 and below. Those versions are already EoL.
|
/cc @nodejs/tsc @nodejs/build Does this have to be semver-major? If the answer is yes, we won't be able to update V8 to 6.8 in Node 10. |
Seems like a question that we are coming to consensus on in nodejs/build#1358. |
|
I don't believe this needs to be semver-major if the older mac os versions are already EoL |
|
For a separate PR, perhaps, but we may want to add a fourth support level that is the opposite of Experimental in that it's something that is heading towards EOL. Right now, we use Experimental for both things that are heading towards EOL and things that we're working on getting more fully supported. The text explaining Experimental implies that it's the latter. A separate label for the former might be useful. |
There was a problem hiding this comment.
Writing this down as a reminder for myself/other Build WG members (or anyone else who would like to contribute), that we'll have to update our build exclusion matrix whenever this lands
|
@Trott I don't think I'm +1 to removing it though. |
There was a problem hiding this comment.
Note that relative 10.10 + 10.9 market share of OS X looks to be high (above 10% of all macs).
But, given that OS X 10.10 reached EoL, and that v8 6.8 is failing to build on it, I don't think that those users have a significant intersection with users that would need to build latest Node.js 10.x on their machines. We have 8.x LTS that should still work there.
Newer v8 for everyone is more important.
Also, this already falls under "The community does not build or test against end-of-life distributions (EoL)", so dropping support for that should not be a semver-major.
|
ping @hashseed regarding #21883 (comment). |
I think this is possible because Chrome and V8 are built using clang from depot_tools and not from Xcode. |
|
Yeah I honestly don't know. V8 did not change anything in particular. We simply pull the clang that Chrome bundles from gclient. If that happens to support OSX 10.10, then I guess we do. |
|
@ChALkeR see nodejs/build#1358 (comment). It won't be possible to build Node from OSX 10.10 but that doesn't mean the binary won't be compatible. |
|
The problem is not with OSX, it's with Xcode. The version of Xcode that is in 10.10 has a bug that makes compilation fail. This bug is fixed in the more recent Xcode that is in 10.11. |
|
I think updating the OS X/Xcode version we use on our infrastructure won't make the builds incompatible with previous OS X versions, but I'm not 100% sure. |
|
Landed in 9453240 |
Starting with V8 6.8, it will not be possible to build with macOS 10.10 and below. Those versions are already EoL. PR-URL: nodejs#21883 Refs: nodejs/build#1358 Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Starting with V8 6.8, it will not be possible to build with macOS 10.10 and below. Those versions are already EoL. PR-URL: #21883 Refs: nodejs/build#1358 Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Starting with V8 6.8, it will not be possible to build with macOS 10.10 and
below. Those versions are already EoL.
Refs: nodejs/build#1358
Checklist